Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds BOOT button as switch to toggle LED #19496

Merged
merged 3 commits into from
Jun 18, 2022
Merged

Adds BOOT button as switch to toggle LED #19496

merged 3 commits into from
Jun 18, 2022

Conversation

jmarcelomb
Copy link
Contributor

Change overview

This pull request adds the the App Task module and the ESP32 boot button ISR to toggle the LED.

Testing

How was this tested?

  • If manually tested, what platforms controller and device platforms were manually tested, and how?
    It was tested in a ESP32 C3. It was compiled and tested using the Python REPL. When it was changed in the REPL it changed the LED and when the button was pressed it was reported the LED state change.

@CLAassistant
Copy link

CLAassistant commented Jun 12, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@restyled-io restyled-io bot mentioned this pull request Jun 12, 2022
Closed
@bzbarsky-apple
Copy link
Contributor

@jmmb13 restyle failures...

@woody-apple
Copy link
Contributor

Fast tracking, given this has had enough time, >3 days for review.

@github-actions
Copy link

github-actions bot commented Jun 16, 2022 •
edited
Loading

PR #19496: Size comparison from 71a9760 to ef114fb

Increases (1 build for cc13x2_26x2)
platform target config section 71a9760 ef114fb change % change
cc13x2_26x2 pump-controller-app LP_CC2652R7 (read/write) 180852 180860 8 0.0
Decreases (3 builds for cc13x2_26x2, efr32, telink)
platform target config section 71a9760 ef114fb change % change
cc13x2_26x2 pump-controller-app LP_CC2652R7 (read only) 661115 661107 -8 -0.0
.text 575540 575532 -8 -0.0
efr32 lock-app BRD4161A+wf200 (read only) 964264 964248 -16 -0.0
.text 964256 964240 -16 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 787564 787556 -8 -0.0
text 558266 558264 -2 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 71a9760 ef114fb change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 658255 658255 0 0.0
(read/write) 192584 192584 0 0.0
.bss 73732 73732 0 0.0
.data 3356 3356 0 0.0
.rodata 86983 86983 0 0.0
.text 570960 570960 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 646731 646731 0 0.0
(read/write) 157292 157292 0 0.0
.bss 73020 73020 0 0.0
.data 3356 3356 0 0.0
.rodata 90315 90315 0 0.0
.text 556096 556096 0 0.0
lock-ftd LP_CC2652R7 (read only) 689151 689151 0 0.0
(read/write) 151800 151800 0 0.0
.bss 70732 70732 0 0.0
.data 3280 3280 0 0.0
.rodata 99071 99071 0 0.0
.text 589596 589596 0 0.0
lock-mtd LP_CC2652R7 (read only) 638567 638567 0 0.0
(read/write) 143864 143864 0 0.0
.bss 66468 66468 0 0.0
.data 3280 3280 0 0.0
.rodata 98951 98951 0 0.0
.text 539124 539124 0 0.0
pump-app LP_CC2652R7 (read only) 670135 670135 0 0.0
(read/write) 171704 171704 0 0.0
.bss 70852 70852 0 0.0
.data 3280 3280 0 0.0
.rodata 87167 87167 0 0.0
.text 582484 582484 0 0.0
pump-controller-app LP_CC2652R7 (read only) 661115 661107 -8 -0.0
(read/write) 180852 180860 8 0.0
.bss 70980 70980 0 0.0
.data 3276 3276 0 0.0
.rodata 85091 85091 0 0.0
.text 575540 575532 -8 -0.0
shell LP_CC2652R7 (read only) 687654 687654 0 0.0
(read/write) 158680 158680 0 0.0
.bss 76028 76028 0 0.0
.data 3360 3360 0 0.0
.rodata 109566 109566 0 0.0
.text 577776 577776 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 611434 611434 0 0.0
.app_xip_area 468124 468124 0 0.0
.bss 86264 86264 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 608750 608750 0 0.0
.app_xip_area 465264 465264 0 0.0
.bss 86440 86440 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 614770 614770 0 0.0
.app_xip_area 472348 472348 0 0.0
.bss 85432 85432 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 921948 921948 0 0.0
(read/write) 132392 132392 0 0.0
.bss 130312 130312 0 0.0
.data 2080 2080 0 0.0
.text 921940 921940 0 0.0
BRD4161A+rpc (read only) 957652 957652 0 0.0
(read/write) 149268 149268 0 0.0
.bss 146984 146984 0 0.0
.data 2284 2284 0 0.0
.text 957644 957644 0 0.0
BRD4161A+rs911x (read only) 796984 796984 0 0.0
(read/write) 128668 128668 0 0.0
.bss 126580 126580 0 0.0
.data 2088 2088 0 0.0
.text 796976 796976 0 0.0
lock-app BRD4161A+wf200 (read only) 964264 964248 -16 -0.0
(read/write) 129044 129044 0 0.0
.bss 126956 126956 0 0.0
.data 2088 2088 0 0.0
.text 964256 964240 -16 -0.0
window-app BRD4161A (read only) 907044 907044 0 0.0
(read/write) 132492 132492 0 0.0
.bss 130384 130384 0 0.0
.data 2108 2108 0 0.0
.text 907036 907036 0 0.0
esp32 all-clusters-app c3devkit (read only) 1011250 1011250 0 0.0
(read/write) 1482786 1482786 0 0.0
.dram0.bss 69368 69368 0 0.0
.dram0.data 14632 14632 0 0.0
.flash.rodata 213344 213344 0 0.0
.flash.text 1011250 1011250 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1065595 1065595 0 0.0
(read/write) 484896 484896 0 0.0
.dram0.bss 74888 74888 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 243868 243868 0 0.0
.flash.text 1060211 1060211 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 657616 657616 0 0.0
.bss 68732 68732 0 0.0
.data 1992 1992 0 0.0
.text 581092 581092 0 0.0
lock k32w061+release (read/write) 719564 719564 0 0.0
.bss 69172 69172 0 0.0
.data 2000 2000 0 0.0
.text 642592 642592 0 0.0
linux all-clusters-app debug (read only) 2923265 2923265 0 0.0
(read/write) 188528 188528 0 0.0
.bss 95744 95744 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84536 84536 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 259357 259357 0 0.0
.text 2487826 2487826 0 0.0
all-clusters-minimal-app debug (read only) 2776977 2776977 0 0.0
(read/write) 180432 180432 0 0.0
.bss 95072 95072 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77176 77176 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 260893 260893 0 0.0
.text 2342178 2342178 0 0.0
bridge-app debug+rpc (read only) 2279705 2279705 0 0.0
(read/write) 159296 159296 0 0.0
.bss 83136 83136 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 66600 66600 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 194240 194240 0 0.0
.text 1924690 1924690 0 0.0
chip-tool debug (read only) 10082645 10082645 0 0.0
(read/write) 610376 610376 0 0.0
.bss 24352 24352 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 578656 578656 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 503829 503829 0 0.0
.text 8171141 8171141 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9827772 9827772 0 0.0
(read/write) 675041 675041 0 0.0
.bss 42625 42625 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614024 614024 0 0.0
.dynamic 528 528 0 0.0
.got 13424 13424 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 467708 467708 0 0.0
.text 7821684 7821684 0 0.0
lighting-app debug+rpc (read only) 2512441 2512441 0 0.0
(read/write) 163320 163320 0 0.0
.bss 83616 83616 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71752 71752 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 209992 209992 0 0.0
.text 2133058 2133058 0 0.0
lock-app debug (read only) 2451113 2451113 0 0.0
(read/write) 157968 157968 0 0.0
.bss 82016 82016 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 68440 68440 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 223688 223688 0 0.0
.text 2063458 2063458 0 0.0
ota-provider-app debug (read only) 2289049 2289049 0 0.0
(read/write) 152136 152136 0 0.0
.bss 81696 81696 0 0.0
.data 1912 1912 0 0.0
.data.rel.ro 62728 62728 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 199864 199864 0 0.0
.text 1927346 1927346 0 0.0
ota-requestor-app debug (read only) 2404777 2404777 0 0.0
(read/write) 158848 158848 0 0.0
.bss 84000 84000 0 0.0
.data 2200 2200 0 0.0
.data.rel.ro 66808 66808 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 203552 203552 0 0.0
.text 2031154 2031154 0 0.0
shell debug (read only) 2596777 2596777 0 0.0
(read/write) 219192 219192 0 0.0
.bss 134504 134504 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 77704 77704 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 229650 229650 0 0.0
.text 2207730 2207730 0 0.0
thermostat-no-ble arm64 (read only) 2564460 2564460 0 0.0
(read/write) 192033 192033 0 0.0
.bss 99473 99473 0 0.0
.data 1688 1688 0 0.0
.data.rel.ro 82776 82776 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 163244 163244 0 0.0
.text 2162448 2162448 0 0.0
tv-app debug (read only) 3060985 3060985 0 0.0
(read/write) 289224 289224 0 0.0
.bss 199240 199240 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 78880 78880 0 0.0
.dynamic 608 608 0 0.0
.got 4840 4840 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 245600 245600 0 0.0
.text 2628882 2628882 0 0.0
tv-casting-app debug (read only) 5543801 5543801 0 0.0
(read/write) 199832 199832 0 0.0
.bss 88072 88072 0 0.0
.data 2480 2480 0 0.0
.data.rel.ro 103048 103048 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 341129 341129 0 0.0
.text 4926562 4926562 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2436264 2436264 0 0.0
.bss 208180 208180 0 0.0
.data 5864 5864 0 0.0
.text 1398908 1398908 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1197451 1197451 0 0.0
bss 141574 141574 0 0.0
rodata 155580 155580 0 0.0
text 821356 821356 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1145423 1145423 0 0.0
bss 140826 140826 0 0.0
rodata 132104 132104 0 0.0
text 793576 793576 0 0.0
p6 all-clusters-app default (read/write) 2551576 2551576 0 0.0
.bss 143360 143360 0 0.0
.data 2776 2776 0 0.0
.text 1509840 1509840 0 0.0
all-clusters-minimal-app default (read/write) 2497424 2497424 0 0.0
.bss 142640 142640 0 0.0
.data 2776 2776 0 0.0
.text 1455688 1455688 0 0.0
light-app default (read/write) 2428160 2428160 0 0.0
.bss 134720 134720 0 0.0
.data 2592 2592 0 0.0
.text 1386424 1386424 0 0.0
lock-app default (read/write) 2448800 2448800 0 0.0
.bss 134544 134544 0 0.0
.data 2600 2600 0 0.0
.text 1407064 1407064 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 787564 787556 -8 -0.0
bss 69868 69868 0 0.0
noinit 40416 40416 0 0.0
text 558266 558264 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 807268 807268 0 0.0
bss 70116 70116 0 0.0
noinit 40416 40416 0 0.0
text 574726 574726 0 0.0

@jmarcelomb
Copy link
Contributor Author

jmarcelomb commented Jun 17, 2022 •
edited
Loading

The unit tests failed due to timeout of bootstrap. How can I solve that?

@bzbarsky-apple
Copy link
Contributor

How can I solve that?

I retriggered the test job....

@andy31415 andy31415 merged commit 24fbe9f into project-chip:master Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jmarcelomb @CLAassistant @bzbarsky-apple @woody-apple @andy31415 @restyled-commits